Skip to content

Added linkcheck to makefile #2403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added linkcheck to makefile #2403

wants to merge 1 commit into from
+10 −13

Conversation

anshuman-agarwala
Copy link
Contributor

What this PR does / why we need it:
Added linkcheck to makefile

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

/area provider/ibmcloud

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

Added linkcheck to makefile

@k8s-ci-robot k8s-ci-robot added the area/provider/ibmcloud Issues or PRs related to ibmcloud provider label Jun 26, 2025
@netlify Netlify
Copy link

netlify bot commented Jun 26, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Name Link
🔨 Latest commit b5c07a0
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-cluster-api-ibmcloud/deploys/6879cb57d269600008cb78aa
😎 Deploy Preview https://deploy-preview-2403.cluster-api-ibmcloud.sigs.k8s.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 26, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: anshuman-agarwala
Once this PR has been reviewed and has the lgtm label, please assign mkumatag for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Hi @anshuman-agarwala. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 26, 2025
@anshuman-agarwala anshuman-agarwala mentioned this pull request Jun 26, 2025
Open
@mkumatag
Copy link
Member

@anshuman-agarwala can you mention more information about why we choose this linter and see if there are any other linters exists for the k8s docs and reuse that here!

btw: this image is in docker hub and we may hit with image pull rate limit issue while running it in the k8s cicd infra

@Prajyot-Parab
Copy link
Contributor

can check (ref - https://github.com/kubernetes/website/blob/main/scripts/linkchecker.py), not sure if this would help us in having something similar

@anshuman-agarwala
Copy link
Contributor Author

@mkumatag I've changed the linter since the earlier one was only hosted on dockerhub.
The current linter I have used is being consumed in other sigs projects as well: https://github.com/search?q=org%3Akubernetes-sigs%20markdown-link-check&type=code

@Amulyam24
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 16, 2025
Amulyam24
Amulyam24 reviewed Jul 16, 2025
View reviewed changes
Copy link
Contributor

@Amulyam24 Amulyam24 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anshuman-agarwala, what do you think about adding linkcheck and yamllint as a part of make verify checks ?

@anshuman-agarwala
Copy link
Contributor Author

@anshuman-agarwala, what do you think about adding linkcheck and yamllint as a part of make verify checks ?

That makes sense, I'll add it.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 16, 2025
@k8s-ci-robot
Copy link
Contributor

@anshuman-agarwala: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-ibmcloud-verify b5c07a0 link true /test pull-cluster-api-provider-ibmcloud-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkumatag mkumatag Awaiting requested review from mkumatag

1 more reviewer

@Amulyam24 Amulyam24 Amulyam24 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
area/provider/ibmcloud Issues or PRs related to ibmcloud provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@anshuman-agarwala @k8s-ci-robot @mkumatag @Prajyot-Parab @Amulyam24